[JIRA] Created: (STS-878) Can never format a Collection/Array using custom formatters with certain Stripes Tags

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[JIRA] Created: (STS-878) Can never format a Collection/Array using custom formatters with certain Stripes Tags

JIRA jira@stripesframework.org
Can never format a Collection/Array using custom formatters with certain Stripes Tags
-------------------------------------------------------------------------------------

                 Key: STS-878
                 URL: http://www.stripesframework.org/jira/browse/STS-878
             Project: Stripes
          Issue Type: Bug
          Components: Formatting, Tag Library
    Affects Versions: Release 1.5.6
            Reporter: Martin Walsh


Certain tags within the Stripes Taglib do not allow you to work with Collections or Arrays.  All tags that use InputTagSupport.getSingleOverrideValue() to obtain the override value for the field get returned the first value in the Collection/Array which is then passed to the Formatting framework to format.  This prevents users from displaying a formatted list of the values, instead always displaying the first value in the collection, even when a CollectionFormatter is present.

What I think should happen is that the tags should use InputTagSupport.getOverrideValueOrValues() and pass the resulting Object off to the formatters.  That way a CollectionFormatter could then be used to format the values accordingly, whether that be to return the first value in the Collection to maintain current behavior, or return a comma separated list of values so that data values are not lost.  This also allows overriding to customise the output, which is currently not possible for Collections/Arrays.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Stripes-development mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/stripes-development
Reply | Threaded
Open this post in threaded view
|

[JIRA] Updated: (STS-878) Can never format a Collection/Array using custom formatters with certain Stripes Tags

JIRA jira@stripesframework.org

     [ http://www.stripesframework.org/jira/browse/STS-878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ben Gunter updated STS-878:
---------------------------

    Fix Version/s: Release 1.5.8

> Can never format a Collection/Array using custom formatters with certain Stripes Tags
> -------------------------------------------------------------------------------------
>
>                 Key: STS-878
>                 URL: http://www.stripesframework.org/jira/browse/STS-878
>             Project: Stripes
>          Issue Type: Bug
>          Components: Formatting, Tag Library
>    Affects Versions: Release 1.5.6
>            Reporter: Martin Walsh
>              Labels: formatting, taglib
>             Fix For: Release 1.5.8
>
>
> Certain tags within the Stripes Taglib do not allow you to work with Collections or Arrays.  All tags that use InputTagSupport.getSingleOverrideValue() to obtain the override value for the field get returned the first value in the Collection/Array which is then passed to the Formatting framework to format.  This prevents users from displaying a formatted list of the values, instead always displaying the first value in the collection, even when a CollectionFormatter is present.
> What I think should happen is that the tags should use InputTagSupport.getOverrideValueOrValues() and pass the resulting Object off to the formatters.  That way a CollectionFormatter could then be used to format the values accordingly, whether that be to return the first value in the Collection to maintain current behavior, or return a comma separated list of values so that data values are not lost.  This also allows overriding to customise the output, which is currently not possible for Collections/Arrays.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Stripes-development mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/stripes-development
Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (STS-878) Can never format a Collection/Array using custom formatters with certain Stripes Tags

JIRA jira@stripesframework.org
In reply to this post by JIRA jira@stripesframework.org

    [ http://www.stripesframework.org/jira/browse/STS-878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885#comment-12885 ]

Remi VANKEISBELCK commented on STS-878:
---------------------------------------

Could you please provide a test case ?

> Can never format a Collection/Array using custom formatters with certain Stripes Tags
> -------------------------------------------------------------------------------------
>
>                 Key: STS-878
>                 URL: http://www.stripesframework.org/jira/browse/STS-878
>             Project: Stripes
>          Issue Type: Bug
>          Components: Formatting, Tag Library
>    Affects Versions: Release 1.5.6
>            Reporter: Martin Walsh
>              Labels: formatting, taglib
>             Fix For: Release 1.5.8
>
>
> Certain tags within the Stripes Taglib do not allow you to work with Collections or Arrays.  All tags that use InputTagSupport.getSingleOverrideValue() to obtain the override value for the field get returned the first value in the Collection/Array which is then passed to the Formatting framework to format.  This prevents users from displaying a formatted list of the values, instead always displaying the first value in the collection, even when a CollectionFormatter is present.
> What I think should happen is that the tags should use InputTagSupport.getOverrideValueOrValues() and pass the resulting Object off to the formatters.  That way a CollectionFormatter could then be used to format the values accordingly, whether that be to return the first value in the Collection to maintain current behavior, or return a comma separated list of values so that data values are not lost.  This also allows overriding to customise the output, which is currently not possible for Collections/Arrays.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
The Go Parallel Website, sponsored by Intel - in partnership with Geeknet,
is your hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials, tech docs,
whitepapers, evaluation guides, and opinion stories. Check out the most
recent posts - join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Stripes-development mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/stripes-development
Reply | Threaded
Open this post in threaded view
|

[JIRA] Updated: (STS-878) Can never format a Collection/Array using custom formatters with certain Stripes Tags

JIRA jira@stripesframework.org
In reply to this post by JIRA jira@stripesframework.org

     [ http://www.stripesframework.org/jira/browse/STS-878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Walsh updated STS-878:
-----------------------------

    Attachment: CollFormatter.tar.gz

Should be a working test case, as requested.

> Can never format a Collection/Array using custom formatters with certain Stripes Tags
> -------------------------------------------------------------------------------------
>
>                 Key: STS-878
>                 URL: http://www.stripesframework.org/jira/browse/STS-878
>             Project: Stripes
>          Issue Type: Bug
>          Components: Formatting, Tag Library
>    Affects Versions: Release 1.5.6
>            Reporter: Martin Walsh
>              Labels: formatting, taglib
>             Fix For: Release 1.5.8
>
>         Attachments: CollFormatter.tar.gz
>
>
> Certain tags within the Stripes Taglib do not allow you to work with Collections or Arrays.  All tags that use InputTagSupport.getSingleOverrideValue() to obtain the override value for the field get returned the first value in the Collection/Array which is then passed to the Formatting framework to format.  This prevents users from displaying a formatted list of the values, instead always displaying the first value in the collection, even when a CollectionFormatter is present.
> What I think should happen is that the tags should use InputTagSupport.getOverrideValueOrValues() and pass the resulting Object off to the formatters.  That way a CollectionFormatter could then be used to format the values accordingly, whether that be to return the first value in the Collection to maintain current behavior, or return a comma separated list of values so that data values are not lost.  This also allows overriding to customise the output, which is currently not possible for Collections/Arrays.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Stripes-development mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/stripes-development
Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (STS-878) Can never format a Collection/Array using custom formatters with certain Stripes Tags

JIRA jira@stripesframework.org
In reply to this post by JIRA jira@stripesframework.org

    [ http://www.stripesframework.org/jira/browse/STS-878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062#comment-13062 ]

Remi VANKEISBELCK commented on STS-878:
---------------------------------------

Thanks for the test case, hadn't seen that sorry. Seems like a netbeans project. How can I build/run the test (without netbeans preferably as I don't have it) ?

> Can never format a Collection/Array using custom formatters with certain Stripes Tags
> -------------------------------------------------------------------------------------
>
>                 Key: STS-878
>                 URL: http://www.stripesframework.org/jira/browse/STS-878
>             Project: Stripes
>          Issue Type: Bug
>          Components: Formatting, Tag Library
>    Affects Versions: Release 1.5.6
>            Reporter: Martin Walsh
>            Assignee: Remi VANKEISBELCK
>              Labels: formatting, taglib
>             Fix For: Release 1.5.8
>
>         Attachments: CollFormatter.tar.gz
>
>
> Certain tags within the Stripes Taglib do not allow you to work with Collections or Arrays.  All tags that use InputTagSupport.getSingleOverrideValue() to obtain the override value for the field get returned the first value in the Collection/Array which is then passed to the Formatting framework to format.  This prevents users from displaying a formatted list of the values, instead always displaying the first value in the collection, even when a CollectionFormatter is present.
> What I think should happen is that the tags should use InputTagSupport.getOverrideValueOrValues() and pass the resulting Object off to the formatters.  That way a CollectionFormatter could then be used to format the values accordingly, whether that be to return the first value in the Collection to maintain current behavior, or return a comma separated list of values so that data values are not lost.  This also allows overriding to customise the output, which is currently not possible for Collections/Arrays.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.  Get
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Stripes-development mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/stripes-development
Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (STS-878) Can never format a Collection/Array using custom formatters with certain Stripes Tags

JIRA jira@stripesframework.org
In reply to this post by JIRA jira@stripesframework.org

    [ http://www.stripesframework.org/jira/browse/STS-878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063#comment-13063 ]

Remi VANKEISBELCK commented on STS-878:
---------------------------------------

Ok I have tested your sample and I don't understand your problem.

You are trying to bind a List<String> with a single field. That ain't how collection binding works in Stripes. You need to use indexed properties in order to do so :
http://www.stripesframework.org/display/stripes/Indexed+Properties

Please provide an actual example of a formatting issue.

> Can never format a Collection/Array using custom formatters with certain Stripes Tags
> -------------------------------------------------------------------------------------
>
>                 Key: STS-878
>                 URL: http://www.stripesframework.org/jira/browse/STS-878
>             Project: Stripes
>          Issue Type: Bug
>          Components: Formatting, Tag Library
>    Affects Versions: Release 1.5.6
>            Reporter: Martin Walsh
>            Assignee: Remi VANKEISBELCK
>              Labels: formatting, taglib
>             Fix For: Release 1.5.8
>
>         Attachments: CollFormatter.tar.gz
>
>
> Certain tags within the Stripes Taglib do not allow you to work with Collections or Arrays.  All tags that use InputTagSupport.getSingleOverrideValue() to obtain the override value for the field get returned the first value in the Collection/Array which is then passed to the Formatting framework to format.  This prevents users from displaying a formatted list of the values, instead always displaying the first value in the collection, even when a CollectionFormatter is present.
> What I think should happen is that the tags should use InputTagSupport.getOverrideValueOrValues() and pass the resulting Object off to the formatters.  That way a CollectionFormatter could then be used to format the values accordingly, whether that be to return the first value in the Collection to maintain current behavior, or return a comma separated list of values so that data values are not lost.  This also allows overriding to customise the output, which is currently not possible for Collections/Arrays.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.  Get
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Stripes-development mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/stripes-development
Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (STS-878) Can never format a Collection/Array using custom formatters with certain Stripes Tags

JIRA jira@stripesframework.org
In reply to this post by JIRA jira@stripesframework.org

    [ http://www.stripesframework.org/jira/browse/STS-878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064#comment-13064 ]

Remi VANKEISBELCK commented on STS-878:
---------------------------------------

Mavenized test case :
https://github.com/vankeisb/stripes-sts-878

> Can never format a Collection/Array using custom formatters with certain Stripes Tags
> -------------------------------------------------------------------------------------
>
>                 Key: STS-878
>                 URL: http://www.stripesframework.org/jira/browse/STS-878
>             Project: Stripes
>          Issue Type: Bug
>          Components: Formatting, Tag Library
>    Affects Versions: Release 1.5.6
>            Reporter: Martin Walsh
>            Assignee: Remi VANKEISBELCK
>              Labels: formatting, taglib
>             Fix For: Release 1.5.8
>
>         Attachments: CollFormatter.tar.gz
>
>
> Certain tags within the Stripes Taglib do not allow you to work with Collections or Arrays.  All tags that use InputTagSupport.getSingleOverrideValue() to obtain the override value for the field get returned the first value in the Collection/Array which is then passed to the Formatting framework to format.  This prevents users from displaying a formatted list of the values, instead always displaying the first value in the collection, even when a CollectionFormatter is present.
> What I think should happen is that the tags should use InputTagSupport.getOverrideValueOrValues() and pass the resulting Object off to the formatters.  That way a CollectionFormatter could then be used to format the values accordingly, whether that be to return the first value in the Collection to maintain current behavior, or return a comma separated list of values so that data values are not lost.  This also allows overriding to customise the output, which is currently not possible for Collections/Arrays.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.  Get
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Stripes-development mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/stripes-development
Reply | Threaded
Open this post in threaded view
|

[JIRA] Resolved: (STS-878) Can never format a Collection/Array using custom formatters with certain Stripes Tags

JIRA jira@stripesframework.org
In reply to this post by JIRA jira@stripesframework.org

     [ http://www.stripesframework.org/jira/browse/STS-878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Remi VANKEISBELCK resolved STS-878.
-----------------------------------

    Resolution: Cannot Reproduce

Resolving as cannot reproduce, please reopen is needed.

> Can never format a Collection/Array using custom formatters with certain Stripes Tags
> -------------------------------------------------------------------------------------
>
>                 Key: STS-878
>                 URL: http://www.stripesframework.org/jira/browse/STS-878
>             Project: Stripes
>          Issue Type: Bug
>          Components: Formatting, Tag Library
>    Affects Versions: Release 1.5.6
>            Reporter: Martin Walsh
>            Assignee: Remi VANKEISBELCK
>              Labels: formatting, taglib
>             Fix For: Release 1.5.8
>
>         Attachments: CollFormatter.tar.gz
>
>
> Certain tags within the Stripes Taglib do not allow you to work with Collections or Arrays.  All tags that use InputTagSupport.getSingleOverrideValue() to obtain the override value for the field get returned the first value in the Collection/Array which is then passed to the Formatting framework to format.  This prevents users from displaying a formatted list of the values, instead always displaying the first value in the collection, even when a CollectionFormatter is present.
> What I think should happen is that the tags should use InputTagSupport.getOverrideValueOrValues() and pass the resulting Object off to the formatters.  That way a CollectionFormatter could then be used to format the values accordingly, whether that be to return the first value in the Collection to maintain current behavior, or return a comma separated list of values so that data values are not lost.  This also allows overriding to customise the output, which is currently not possible for Collections/Arrays.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.  Get
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Stripes-development mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/stripes-development