[JIRA] Created: (STS-921) Response code 404 returned with DMF on IBM WebSphere Liberty

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[JIRA] Created: (STS-921) Response code 404 returned with DMF on IBM WebSphere Liberty

JIRA jira@stripesframework.org
Response code 404 returned with DMF on IBM WebSphere Liberty
-------------------------------------------------------------

                 Key: STS-921
                 URL: http://www.stripesframework.org/jira/browse/STS-921
             Project: Stripes
          Issue Type: Bug
          Components: ActionBean Dispatching
    Affects Versions: Release 1.5.7, Release 1.5.8, Release 1.6
            Reporter: Remi VANKEISBELCK
            Assignee: Remi VANKEISBELCK


When using DMF on WebSphere Liberty, we have 404 response even when DMF picks an action bean and uses it for the request.

When DMF calls chain.doFilter(), it passes the error trapping request wrapper. This one overrides sendError() methods.

With Tomcat, the original response (not wrapper) has a status code 200 when the Dispatcher is invoked with the bean found. The method sendError() is called on the wrapper, which doesn't modify the original (wrapped) response's status code, but sets a private field.
 
Liberty doesn't invoke sendError(). Instead it calls setStatus() ! This modifies the original response, which then has a 404 return code...

We need to override setStatus() as well in ErrorTrappingResponseWrapper, and update the private fields of the wrapper, instead of letting the original response be modified.



--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
Stripes-development mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/stripes-development
Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (STS-921) Response code 404 returned with DMF on IBM WebSphere Liberty

JIRA jira@stripesframework.org

    [ http://www.stripesframework.org/jira/browse/STS-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13110#comment-13110 ]

Remi VANKEISBELCK commented on STS-921:
---------------------------------------

This is resolved in github :
master : https://github.com/StripesFramework/stripes/commit/00cfd60d5259f4c8426f55a8fc1263d79322e122
1.5.x : https://github.com/StripesFramework/stripes/commit/1af4c18deb5511e7bf534550fc899f3cfa7cb52b

Waiting for the new 1.5.9 JIRA release to be available before closing.  


> Response code 404 returned with DMF on IBM WebSphere Liberty
> -------------------------------------------------------------
>
>                 Key: STS-921
>                 URL: http://www.stripesframework.org/jira/browse/STS-921
>             Project: Stripes
>          Issue Type: Bug
>          Components: ActionBean Dispatching
>    Affects Versions: Release 1.5.7, Release 1.5.8, Release 1.6
>            Reporter: Remi VANKEISBELCK
>            Assignee: Remi VANKEISBELCK
>
> When using DMF on WebSphere Liberty, we have 404 response even when DMF picks an action bean and uses it for the request.
> When DMF calls chain.doFilter(), it passes the error trapping request wrapper. This one overrides sendError() methods.
> With Tomcat, the original response (not wrapper) has a status code 200 when the Dispatcher is invoked with the bean found. The method sendError() is called on the wrapper, which doesn't modify the original (wrapped) response's status code, but sets a private field.
>  
> Liberty doesn't invoke sendError(). Instead it calls setStatus() ! This modifies the original response, which then has a 404 return code...
> We need to override setStatus() as well in ErrorTrappingResponseWrapper, and update the private fields of the wrapper, instead of letting the original response be modified.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
Stripes-development mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/stripes-development
Reply | Threaded
Open this post in threaded view
|

[JIRA] Resolved: (STS-921) Response code 404 returned with DMF on IBM WebSphere Liberty

JIRA jira@stripesframework.org
In reply to this post by JIRA jira@stripesframework.org

     [ http://www.stripesframework.org/jira/browse/STS-921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Remi VANKEISBELCK resolved STS-921.
-----------------------------------

    Resolution: Fixed

> Response code 404 returned with DMF on IBM WebSphere Liberty
> -------------------------------------------------------------
>
>                 Key: STS-921
>                 URL: http://www.stripesframework.org/jira/browse/STS-921
>             Project: Stripes
>          Issue Type: Bug
>          Components: ActionBean Dispatching
>    Affects Versions: Release 1.5.8
>            Reporter: Remi VANKEISBELCK
>            Assignee: Remi VANKEISBELCK
>             Fix For: Release 1.5.9, Release 1.6
>
>
> When using DMF on WebSphere Liberty, we have 404 response even when DMF picks an action bean and uses it for the request.
> When DMF calls chain.doFilter(), it passes the error trapping request wrapper. This one overrides sendError() methods.
> With Tomcat, the original response (not wrapper) has a status code 200 when the Dispatcher is invoked with the bean found. The method sendError() is called on the wrapper, which doesn't modify the original (wrapped) response's status code, but sets a private field.
>  
> Liberty doesn't invoke sendError(). Instead it calls setStatus() ! This modifies the original response, which then has a 404 return code...
> We need to override setStatus() as well in ErrorTrappingResponseWrapper, and update the private fields of the wrapper, instead of letting the original response be modified.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
Stripes-development mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/stripes-development
Reply | Threaded
Open this post in threaded view
|

[JIRA] Updated: (STS-921) Response code 404 returned with DMF on IBM WebSphere Liberty

JIRA jira@stripesframework.org
In reply to this post by JIRA jira@stripesframework.org

     [ http://www.stripesframework.org/jira/browse/STS-921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Remi VANKEISBELCK updated STS-921:
----------------------------------

        Fix Version/s: Release 1.6
                       Release 1.5.9
    Affects Version/s:     (was: Release 1.5.7)
                           (was: Release 1.6)

> Response code 404 returned with DMF on IBM WebSphere Liberty
> -------------------------------------------------------------
>
>                 Key: STS-921
>                 URL: http://www.stripesframework.org/jira/browse/STS-921
>             Project: Stripes
>          Issue Type: Bug
>          Components: ActionBean Dispatching
>    Affects Versions: Release 1.5.8
>            Reporter: Remi VANKEISBELCK
>            Assignee: Remi VANKEISBELCK
>             Fix For: Release 1.5.9, Release 1.6
>
>
> When using DMF on WebSphere Liberty, we have 404 response even when DMF picks an action bean and uses it for the request.
> When DMF calls chain.doFilter(), it passes the error trapping request wrapper. This one overrides sendError() methods.
> With Tomcat, the original response (not wrapper) has a status code 200 when the Dispatcher is invoked with the bean found. The method sendError() is called on the wrapper, which doesn't modify the original (wrapped) response's status code, but sets a private field.
>  
> Liberty doesn't invoke sendError(). Instead it calls setStatus() ! This modifies the original response, which then has a 404 return code...
> We need to override setStatus() as well in ErrorTrappingResponseWrapper, and update the private fields of the wrapper, instead of letting the original response be modified.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
Stripes-development mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/stripes-development